Repository navigation
Conversation
There was a problem hiding this comment.
馃煛 Changes recommended
Quota reconciliation can incorrectly block available capacity, and retry-delay calculation and reporting need correction.
4 open findings
What changed in this PR
Adds coordinated rate-limit handling to the management REST transport for synchronous and asynchronous callers.
Changes:
- Shares quota reservations across routes by origin and API key.
- Adds bounded retries, Retry-After handling, and jittered backoff.
- Introduces
RateLimitError, documentation, and regression tests.
| File | Description |
|---|---|
| tests/鈥媡est_api/鈥媡est_rate_limit.py | Tests quota coordination, retries, budgets, and cancellation. |
| runpod/鈥媏rror.py | Adds RateLimitError with retry-delay details. |
| runpod/鈥媋pi/鈥媟est.py | Integrates shared quotas and bounded retries. |
| runpod/鈥媋pi/鈥媉rate_limit.py | Implements parsing, reservations, cooldowns, and registry management. |
| docs/鈥媋pi/鈥媓andling_errors.md | Documents rate-limit behavior and configuration. |
馃 Review effort: Balanced
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
deanq
reviewed
Oct 15, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Honor
Retry-Afterand use jittered exponential backoff when no valid hint is available. Retry and wait budgets surfaceRateLimitErrorwhen exhausted.